Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Invoice Ninja Node): Fix actions for bank transactions #11511

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Contributor

Summary

When I attempted to use the changes from #10389 I ran into 3 minor issues which this PR attempts to fix.

  • Creating a bank transaction would always use USD as currency as there was no currency_id field in the bank transaction body. Now all available currencies are retrieved via InvoiceNinja's API and the currency for a bank transaction can be adopted.
  • The API call for matching bank transactions to a payment expects a payment_id param. This was mistakenly named paymentId.
  • The API call for matching bank transactions to a payment also expects an array of transactions like this:
{
  "transactions": [
    {
        "id": "{{TRANSACTION_ID}}",
        "payment_id": "{{PAYMENT_ID}}"
    }
  ]
}

The current implementation only provided one transaction object which didn't satisfy the InvoiceNinja API.

Related Linear tickets, Github issues, and Community forum posts

Follow-up of #10389

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Nov 1, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 1, 2024

Hey @CodeShakingSheep,

Thanks for the PR, We have created "GHC-376" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants