fix(Invoice Ninja Node): Fix actions for bank transactions #11511
+51
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I attempted to use the changes from #10389 I ran into 3 minor issues which this PR attempts to fix.
currency_id
field in the bank transaction body. Now all available currencies are retrieved via InvoiceNinja's API and the currency for a bank transaction can be adopted.payment_id
param. This was mistakenly namedpaymentId
.The current implementation only provided one transaction object which didn't satisfy the InvoiceNinja API.
Related Linear tickets, Github issues, and Community forum posts
Follow-up of #10389
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)